search

WIPACrepo / file_catalog

Store file metadata information in a file catalog
MIT License
1 stars 4 forks source link

Use `rest_tools.server.RestHandler` for Full Tracing #124

Closed ric-evans closed 2 years ago

ric-evans commented 2 years ago

Adds full WIPACTEL instrumentation

closes https://github.com/WIPACrepo/file_catalog/issues/122

ric-evans commented 2 years ago

This is just a bit more than the minimum necessary to get auto-instrumented traces with the FC.

It doesn't use rest_tools.handler.RestHandlerSetup, that would take a lot more work than is necessary. It's also not using the auth wrappers: @scope_role_auth() or @role_authorization() (@dsschult, feel free to look at that if you want).

ric-evans commented 2 years ago

I notice in rest-tools v1.1.23 that mypy doesn't really like the way we use types; there are more comments to override type 'errors' than before. Not sure if that's mypy being too picky or us being too loose / going against the grain / etc. Not that I'm volunteering to re-design the RestHandler API! sweat_smile Just thinking about the health of our canary as we descend into the coal mine.

@blinkdog I saw this in your comment on https://github.com/WIPACrepo/lta/issues/216. What are the actual mypy complaints/errors/warnings you're seeing? The CircleCI mypy job looks fine.

lgtm-com[bot] commented 2 years ago

This pull request introduces 8 alerts and fixes 5 when merging 06bba4377f22965323c7264e2ee65cf6e33c8d47 into e98eeb5d4e09a6cfdf9ac72a1906d04c7d797ab6 - view on LGTM.com

new alerts:

fixed alerts: