Keycloak Authentication

[blinkdog]

File Catalog Auth Update

• File Catalog now requires at least Python 3.8
• Migrated CircleCI config.yml to GitHub Actions profile_queries.yml
• Updated wipac-cicd.yml
• Cleaned up CircleCI and Vagrant references in README.md
• Modified environment variables listed in file-catalog.sh script
• Removed __future__ imports; the future is now!
• Fixed flake8 and mypy issues across the codebase
• Modified __main__.py to use asyncio.run loop
• Modified server.py to use new keycloak_role_auth <-- Hey, I knew there was auth in here somewhere!
• Removed web interface stubs from server.py
• Rewrote urlargparse to handle parsing complex jQuery style URL args
• Modified route handlers to use 'raise HTTPError' instead of 'send_error'
• Removed catch handlers for pymongo.errors.InvalidId (removed from PyMongo)
• Moved dev requirements to setup.cfg; bot now maintains requirements-dev.txt
• Added suru script as a development helper
• Created PyTest fixtures in conftest.py
• Migrated unit tests to async-compatible PyTest unit tests

Closes #111 Closes #135

[blinkdog]

The bot updated requirements.txt and pinned the conflicted requirements to specific versions. suru check may suggest upgrades that can't really be done.

googleapis-common-protos can be upgraded from 1.56.2 to 1.58.0
protobuf can be upgraded from 3.20.3 to 4.21.12
pyjwt can be upgraded from 2.5.0 to 2.6.0

[ric-evans]

The bot updated requirements.txt and pinned the conflicted requirements to specific versions. suru check may suggest upgrades that can't really be done.

googleapis-common-protos can be upgraded from 1.56.2 to 1.58.0
protobuf can be upgraded from 3.20.3 to 4.21.12
pyjwt can be upgraded from 2.5.0 to 2.6.0

ack! protobuf has had conflicting version bumps for a while now... it wouldn't be the worse thing to pin these in setup.cfg. We'll just have to remember to bump them later-- O(months)

[dsschult]

The bot updated requirements.txt and pinned the conflicted requirements to specific versions. suru check may suggest upgrades that can't really be done.

googleapis-common-protos can be upgraded from 1.56.2 to 1.58.0
protobuf can be upgraded from 3.20.3 to 4.21.12
pyjwt can be upgraded from 2.5.0 to 2.6.0

ack! protobuf has had conflicting version bumps for a while now... it wouldn't be the worse thing to pin these in setup.cfg. We'll just have to remember to bump them later-- O(months)

Given that the bot is pretty smart (it knows about pinned dependencies anywhere in the dependency chain), and also checks on every commit, does suru check add any value?

[dsschult]

Note: in many of our projects, we've started doing

pip install .[tests]

in the pytest action, and listing all the test deps in setup.cfg.

This has the advantage that the bot will keep the resulting requirements.txt file up to date, if it is ever needed (it's usually more of a record of what versions passed the CI tests).

[dsschult]

I think this wins largest PR of the year so far :smile:

Nope, IceProd is still winning: https://github.com/WIPACrepo/iceprod/pull/323

[blinkdog]

The bot updated requirements.txt and pinned the conflicted requirements to specific versions. suru check may suggest upgrades that can't really be done.

googleapis-common-protos can be upgraded from 1.56.2 to 1.58.0
protobuf can be upgraded from 3.20.3 to 4.21.12
pyjwt can be upgraded from 2.5.0 to 2.6.0

ack! protobuf has had conflicting version bumps for a while now... it wouldn't be the worse thing to pin these in setup.cfg. We'll just have to remember to bump them later-- O(months)

Given that the bot is pretty smart (it knows about pinned dependencies anywhere in the dependency chain), and also checks on every commit, does suru check add any value?

It's a helper script; it just helps me keep tabs on things. My comment was more of a note-to-self: you can't upgrade these things quite yet.

[blinkdog]

Note: in many of our projects, we've started doing

pip install .[tests]

in the pytest action, and listing all the test deps in setup.cfg.

This has the advantage that the bot will keep the resulting requirements.txt file up to date, if it is ever needed (it's usually more of a record of what versions passed the CI tests).

I've added this as an [options.extras_require] section in setup.cfg and modified the CI and setup scripts. Does that work?

[blinkdog]

I think we got most of the issues cleaned up, except #111 . I'm going to cut bait and work on that tomorrow.

[ric-evans]

Note: in many of our projects, we've started doing

pip install .[tests]

in the pytest action, and listing all the test deps in setup.cfg. This has the advantage that the bot will keep the resulting requirements.txt file up to date, if it is ever needed (it's usually more of a record of what versions passed the CI tests).

I've added this as an [options.extras_require] section in setup.cfg and modified the CI and setup scripts. Does that work?

That's it! It's a smart bot :robot:

[ric-evans]

Nice add! Let's see if this works: closes #111

[ric-evans]

What's the status of this PR?

[blinkdog]

What's the status of this PR?

Ready to merge. I'll probably do so this afternoon.