search

WIPACrepo / file_catalog

Store file metadata information in a file catalog
MIT License
1 stars 4 forks source link

PFFilt metadata #52

Closed ric-evans closed 4 years ago

ric-evans commented 4 years ago

Refactored a lot but the same logic is still there. Essentially class inheritance has replaced if-blocks for processing levels. Added support for PFFilt files.

dsschult commented 4 years ago

Looks like there are some conflicts with master. Those need to get resolved.

dsschult commented 4 years ago

There is a lot of functionality here that deals with lots of fiddly parsing details. I'd recommend writing some unit tests to help flush out any bugs.

I'm unsure how much unit tests will help, especially since you need the actual files to get useful metadata. But if we do go that route, this stops becoming a helper script and becomes part of the main project (or a separate project).

dsschult commented 4 years ago

At this point most of my complaints are addressed, and I'll list it as approved.

blinkdog commented 4 years ago

The only comment I'd really like to see a decision on is: https://github.com/WIPACrepo/file_catalog/pull/52#discussion_r376178609

The rest looks very good, and ready to merge.