search

WIPACrepo / file_catalog

Store file metadata information in a file catalog
MIT License
1 stars 4 forks source link

Logging Format Updates #67

Closed ric-evans closed 3 years ago

ric-evans commented 3 years ago

Biggest bonus is that coloredlogs includes a timestamp which will make debugging easier

dsschult commented 3 years ago

My feelings about colored logs are "meh." (I can change the log formatting to include a timestamp in the python logger too)

But I won't object to it if you want to use colored logs.

ric-evans commented 3 years ago

My feelings about colored logs are "meh." (I can change the log formatting to include a timestamp in the python logger too)

But I won't object to it if you want to use colored logs.

k8s logs won't forward the coloring unfortunately (yet?). But, the base formatting is nice, even though that can be done with just logging.basicConfig()

blinkdog commented 3 years ago

Ahhh coloring, takes me back to the days of crafting ANSI escape codes to make output pretty in dial-up modem terminal programs and MS-DOS.

This does make logs harder to use in plain text editors, but there are ways to filter ANSI codes so heck, why not? :smile:

dsschult commented 3 years ago

note that coloredlogs is aware of the terminal type and won't input ASNI codes into non-interactive terminals (unless you really, really tell it to)