WIPACrepo / keycloak-rest-services

Services surrounding KeyCloak, that use the REST API to read/update state
MIT License
1 stars 1 forks source link

handle differences in attrs for list_insts_flat, by using a whitelist #44

Closed dsschult closed 2 years ago

dsschult commented 2 years ago

Allows a successful run with

python -m krs.institutions list-name --attr has_mou --attr cite --attr name --attr abbreviation --attr region --attr is_US --attr institutionLeadUid
ric-evans commented 2 years ago

What are your thoughts about making attr_whitelist a required param?

dsschult commented 2 years ago

What are your thoughts about making attr_whitelist a required param?

I'm not sure it really is required, even though it is very useful for the mou dashboard. Just thinking of other uses, like if you wanted just the names of the CTA institutions. You wouldn't care about the whitelist and matching, just that it got flattened.

lgtm-com[bot] commented 2 years ago

This pull request introduces 1 alert when merging 28bdae95020f1f49dfea92288f6ec12d39d16dc8 into 2661b0db2dd320bdb8eefc62c805188bec52ecc7 - view on LGTM.com

new alerts: