search

WISDEM / LandBOSSE

New LandBOSSE Model (Developed in 2018-2019)
Other
17 stars 25 forks source link

Issue 111 integrate dw erection: Merge private (LandBOSSE-dev) ErectionCost module into public ErectionCost module #122

Closed barker59 closed 4 years ago

barker59 commented 4 years ago

Integrates DW functionality from LandBOSSE-dev Ready for review.

parangat94 commented 4 years ago

Parangat currently reviewing this.

parangat94 commented 4 years ago

@akey7 @eberlea ready for review.

akey7 commented 4 years ago

@barker59 Please see my email about validation.

barker59 commented 4 years ago

@akey7 Made requested changes. Removed doubling of mobilization cost for both DW and non-DW projects in ErectionCost.py

parangat94 commented 4 years ago

@barker59 @akey7 is this ready to be merged?

akey7 commented 4 years ago

@barker59 @parangat94 Now all the Erection mobilization validation cases, DW and non-DW, are broken. So it is not ready to merge yet.

parangat94 commented 4 years ago

@akey7 merged develop into branch issue_108_integrate_DW followed by merge of issue_108_integrate_DW into current branch (issue_111_integrate_DW_Erection).

PR ready for final review.