search

WISDEM / LandBOSSE

New LandBOSSE Model (Developed in 2018-2019)
Other
17 stars 25 forks source link

Issue 117 Merge private CollectionCost into public CollectionCost module #128

Closed parangat94 closed 4 years ago

parangat94 commented 4 years ago

Ready for review.

akey7 commented 4 years ago

@parangat94 Has there been any movement ahead on @eberlea comments? Once those changes are made and @eberlea approves, I will do my review.

parangat94 commented 4 years ago

@eberlea @akey7 ready for review. I've made changes per your requests and re-ran the validation. Please see results below:

Important: Please note there is new expected validation data on the box. I made some minor tweaks to the expected collection cost breakdown (which were showing some minor discrepancies in expected value due to legacy bugs)

eberlea commented 4 years ago

I'm reviewing this now. I've flagged some additional comments that need to be addressed before merging. I'll let you know when I'm done reviewing and it's ready for you to make final changes before merging.

parangat94 commented 4 years ago

@akey7 merged develop into branch issue_108_integrate_DW, followed by merge of issue_108_integrate_DW into current branch (issue_117_integrate_DW_collection).

PR ready for final review.