WISDEM / WEIS

Wind Energy with Integrated Servo-controls Toolset
https://weis.readthedocs.io/en/latest/
Apache License 2.0
51 stars 38 forks source link

No Flap Actuation in WEIS/examples/07_te_flaps example simulation #200

Closed DeepFriedDerp closed 8 months ago

DeepFriedDerp commented 1 year ago

Description

Develop Branch, example 07_te_flaps appears to be incapable of producing flap actuation as currently set up.

Found by:

Steps to reproduce issue

  1. Install from develop branch
  2. From WEIS/examples/07_te_flaps, run dac_driver.py to run simulation
  3. Validate claims from issue description using the .out and/or .outb files from the 07_te_flaps/temp directory.

Current behavior

Expected behavior

dzalkind commented 1 year ago

I think AfCmode is not being set. Can you verify this from the OpenFAST inputs?

I would set it around here with

self.modeling_options['Level3']['ServoDyn']['AfCmode'] = 5

Sorry, I am not set up with XFoil or working on flap control much, so I might not be able to provide a lot of good support/testing for this.

DeepFriedDerp commented 1 year ago

@dzalkind, this fixed the problem!

I'd recommend committing the change you suggested, because I don't think example 07 will work properly without it.

Thanks so much!

DeepFriedDerp commented 1 year ago

As a quick follow-up:

You can also fix this problem by adding "AfCmode: 5" to the ServoDyn section of the example modeling_options.yaml

This will avoid having to make any changes to the general code if that's what is desired, but I like the idea of baking it into a conditional statement like @dzalkind suggested, since any flap control option will probably need it.

Thanks again for the help!

DeepFriedDerp commented 1 year ago

This issue has been open for a while, so I'll add a new issue that I ran into while working with this example.

In BAR_USC_flaps.yaml, under components/blade/aerodynamic_control/te_flaps, the span_start and span_end are very close to each other (0.7 and 0.71, respectively). When I was running examples comparing the different flap modes, I was getting no discernible difference in turbine response, despite the very different blade flap behavior (the plots of tip deflection and root bending moments were visually identical).

@Ben-Mertz figured out this was the cause of the apparent lack of turbine response, and has verified that increasing the amount of span occupied by the te flaps does produce a more noticeable response. Because this is an example, meant to demonstrate to a new user how to integrate te flaps into their model, it may be a good idea in a future commit to increase the initial span of the te flaps in the BAR_USC_flaps.yaml

ptrbortolotti commented 1 year ago

PR #213 should help close this issue