WISDEM / WEIS

Wind Energy with Integrated Servo-controls Toolset
https://weis.readthedocs.io/en/latest/
Apache License 2.0
53 stars 40 forks source link

bug fix in vizFileGen and changes to handle Jul 2024 Kestrel updates #306

Closed mayankchetan closed 3 months ago

mayankchetan commented 3 months ago

Purpose

Minor bug fixes for WEIS Viz input generation tool. Changes to kestrel installation script to handle the Jul 2024 Kestrel updates

Type of change

What types of change is it? Select the appropriate type(s) that describe this PR

Testing

Tested on Kestrel on 01AUG24

Checklist

Put an x in the boxes that apply.

dzalkind commented 3 months ago

Thanks @mayankchetan! When this is ready, can you assign a reviewer?

mayankchetan commented 3 months ago

@sora-ryu Can you review these changes?

@dzalkind, we might have to add @sora-ryu to the repo as a contributor.

sora-ryu commented 3 months ago

Hey @mayankchetan , the viz file generation works well with raft optimization, but having some error on openfast optimization. Do you want to check on this?

image

mayankchetan commented 3 months ago

Can you try again after updating your WEIS env? I think these are recent changes.

sora-ryu commented 3 months ago

Hmm, I am having a same error after reinstallation as well.

sora-ryu commented 3 months ago

@mayankchetan - I just temporarily changed modeling and geometry input yaml files for now and it works fine. (1. Manually changed the floating platform member types Ca and Cd from singular value to array type. 2. Set path2dll path as none, as it couldn't find the library)

I PRed on your repo with some minor changes that include type and default channel settings. After that, looks like ready to go.

mayankchetan commented 3 months ago

@dzalkind, I think this is good to merge