WISDEM / WEIS

Wind Energy with Integrated Servo-controls Toolset
https://weis.readthedocs.io/en/latest/
Apache License 2.0
53 stars 40 forks source link

Upgrade mpi #321

Closed ptrbortolotti closed 1 week ago

ptrbortolotti commented 1 week ago

Purpose

This PR goes together with https://github.com/WISDEM/WISDEM/pull/583, where we've removed some of our own MPI logic and we started using the OpenMDAO one, which was less mature years ago and has now caught up. Note that WEIS uses a more sophisticated parallelization logic than WISDEM, with the color mapping dispatching OpenFAST jobs around the node(s), and so some of the scripts that could be removed from WISDEM had to be moved to WEIS

Type of change

What types of change is it? Select the appropriate type(s) that describe this PR

Testing

Tests should be passing successfully

Checklist

Put an x in the boxes that apply.

ptrbortolotti commented 1 week ago

shortly we will need to tag a new version of https://github.com/WISDEM/WISDEM and point to it from the environment file...

dzalkind commented 1 week ago

Thanks, for looking into this @ptrbortolotti!

I see you added some of the code from WISDEM to WEIS about computing the number of DVs in the blade optimization and others. Why do those need to be counted manually and which ones are counted automatically by openmdao?