WISDEM / WOMBAT

Windfarm Operations & Maintenance cost-Benefit Analysis Tool
https://wisdem.github.io/WOMBAT/
Apache License 2.0
20 stars 11 forks source link

Bug Fix: Repair duplication and multiple completions #101

Closed RHammond2 closed 1 year ago

RHammond2 commented 1 year ago

This PR addresses three inter-related issues:

  1. Operating levels > 100% due to the subassembly reset process' improper use of multiple if statements in place of a longer if/elif block
  2. Repairs being completed more than once due to an improper recursive loop in the crew transfer mechanisms during shift delays
  3. Repairs having equipment dispatched more than once due to inconsistent handling of pending, processing, and completed repair statuses

See the changelog for complete details.

codecov[bot] commented 1 year ago

Codecov Report

Merging #101 (580d3eb) into develop (503abf4) will increase coverage by 0.12%. The diff coverage is 45.88%.

@@             Coverage Diff             @@
##           develop     #101      +/-   ##
===========================================
+ Coverage    54.57%   54.69%   +0.12%     
===========================================
  Files           21       21              
  Lines         3500     3556      +56     
  Branches       709      720      +11     
===========================================
+ Hits          1910     1945      +35     
- Misses        1473     1491      +18     
- Partials       117      120       +3     
Files Changed Coverage Δ
wombat/core/port.py 15.55% <9.37%> (-1.54%) :arrow_down:
wombat/core/service_equipment.py 62.41% <61.90%> (+2.08%) :arrow_up:
wombat/core/repair_management.py 67.65% <70.00%> (-0.72%) :arrow_down:
wombat/core/data_classes.py 85.71% <100.00%> (+0.05%) :arrow_up: