WISDEM / WOMBAT

Windfarm Operations & Maintenance cost-Benefit Analysis Tool
https://wisdem.github.io/WOMBAT/
Apache License 2.0
21 stars 11 forks source link

Bug Fix: Ensure system downtime starts appropriately #111

Closed RHammond2 closed 1 year ago

RHammond2 commented 1 year ago

This PR addresses a series of logic holes:

See the changelog for complete details. All changes result in a small net positive increase in availability due to better resolved timing of shut downs and repairs.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 49.57% and project coverage change: +0.32% :tada:

Comparison is base (c2f530a) 54.69% compared to head (403eef1) 55.02%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #111 +/- ## =========================================== + Coverage 54.69% 55.02% +0.32% =========================================== Files 21 21 Lines 3607 3669 +62 Branches 730 745 +15 =========================================== + Hits 1973 2019 +46 - Misses 1512 1528 +16 Partials 122 122 ``` | [Files Changed](https://app.codecov.io/gh/WISDEM/WOMBAT/pull/111?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=WISDEM) | Coverage Δ | | |---|---|---| | [wombat/core/port.py](https://app.codecov.io/gh/WISDEM/WOMBAT/pull/111?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=WISDEM#diff-d29tYmF0L2NvcmUvcG9ydC5weQ==) | `14.75% <0.00%> (-0.33%)` | :arrow_down: | | [wombat/core/repair\_management.py](https://app.codecov.io/gh/WISDEM/WOMBAT/pull/111?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=WISDEM#diff-d29tYmF0L2NvcmUvcmVwYWlyX21hbmFnZW1lbnQucHk=) | `63.01% <30.23%> (-5.79%)` | :arrow_down: | | [wombat/core/service\_equipment.py](https://app.codecov.io/gh/WISDEM/WOMBAT/pull/111?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=WISDEM#diff-d29tYmF0L2NvcmUvc2VydmljZV9lcXVpcG1lbnQucHk=) | `65.25% <80.85%> (+3.23%)` | :arrow_up: | | [wombat/core/environment.py](https://app.codecov.io/gh/WISDEM/WOMBAT/pull/111?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=WISDEM#diff-d29tYmF0L2NvcmUvZW52aXJvbm1lbnQucHk=) | `77.15% <100.00%> (+0.25%)` | :arrow_up: | | [wombat/windfarm/system/cable.py](https://app.codecov.io/gh/WISDEM/WOMBAT/pull/111?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=WISDEM#diff-d29tYmF0L3dpbmRmYXJtL3N5c3RlbS9jYWJsZS5weQ==) | `76.22% <100.00%> (+0.33%)` | :arrow_up: | | [wombat/windfarm/system/system.py](https://app.codecov.io/gh/WISDEM/WOMBAT/pull/111?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=WISDEM#diff-d29tYmF0L3dpbmRmYXJtL3N5c3RlbS9zeXN0ZW0ucHk=) | `92.00% <100.00%> (+0.21%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.