WISDEM / WOMBAT

Windfarm Operations & Maintenance cost-Benefit Analysis Tool
https://wisdem.github.io/WOMBAT/
Apache License 2.0
21 stars 11 forks source link

Bug Fix: Keep logged events within the timing bounds #120

Closed RHammond2 closed 1 year ago

RHammond2 commented 1 year ago

This PR resolves an edge case where a crew transfer gets initiated for midnight after the end of the last day of the simulation by checking the timestamp in the environment's logging method and ignoring any log occurring after that.

codecov[bot] commented 1 year ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (3a429ff) 55.93% compared to head (5bb8157) 55.73%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #120 +/- ## =========================================== - Coverage 55.93% 55.73% -0.20% =========================================== Files 21 21 Lines 3570 3563 -7 Branches 739 738 -1 =========================================== - Hits 1997 1986 -11 - Misses 1452 1456 +4 Partials 121 121 ``` | [Files](https://app.codecov.io/gh/WISDEM/WOMBAT/pull/120?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=WISDEM) | Coverage Δ | | |---|---|---| | [wombat/core/environment.py](https://app.codecov.io/gh/WISDEM/WOMBAT/pull/120?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=WISDEM#diff-d29tYmF0L2NvcmUvZW52aXJvbm1lbnQucHk=) | `76.86% <66.66%> (-0.29%)` | :arrow_down: | ... and [4 files with indirect coverage changes](https://app.codecov.io/gh/WISDEM/WOMBAT/pull/120/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=WISDEM)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.