WISDEM / WOMBAT

Windfarm Operations & Maintenance cost-Benefit Analysis Tool
https://wisdem.github.io/WOMBAT/
Apache License 2.0
20 stars 11 forks source link

Deprecate `Configuration.library_path` #122

Closed RHammond2 closed 11 months ago

RHammond2 commented 11 months ago

This PR deprecates the duplicated requirement for a library_path in Configuration and Simulation with the most significant change coming from Simulation.from_config, which now requires 2 inputs library_path and config.

codecov[bot] commented 11 months ago

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (e4591f4) 53.73% compared to head (086dc0f) 53.76%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #122 +/- ## =========================================== + Coverage 53.73% 53.76% +0.03% =========================================== Files 22 22 Lines 3726 3722 -4 Branches 767 765 -2 =========================================== - Hits 2002 2001 -1 + Misses 1602 1599 -3 Partials 122 122 ``` | [Files](https://app.codecov.io/gh/WISDEM/WOMBAT/pull/122?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=WISDEM) | Coverage Δ | | |---|---|---| | [wombat/core/simulation\_api.py](https://app.codecov.io/gh/WISDEM/WOMBAT/pull/122?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=WISDEM#diff-d29tYmF0L2NvcmUvc2ltdWxhdGlvbl9hcGkucHk=) | `51.32% <33.33%> (+0.90%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.