refactor(TeacherProjectService): Extract CreateComponentService - Githubissues

WISE-Community / WISE-Client

Client-side code for WISE

Other

3 stars 4 forks source link

refactor(TeacherProjectService): Extract CreateComponentService #1911

Closed hirokiterashima closed 2 months ago

hirokiterashima commented 3 months ago

Changes

Extract functions related to creating a component from TeacherProjectService.createComponent() to CreateComponentService.create()
Refactor addComponentToNode()
Add tests
Remove unused function TeacherProjectService.removeNodeIdFromInactiveNodes()

Test

In the AT, creating new component(s) works as before. Verify that the new component is placed correctly.
- Add your own node. Try adding multiple components
- Edit step view. Try adding component at the beginning and after an existing component

hirokiterashima commented 2 months ago

:tada: This issue has been resolved in version 5.156.2 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: