feat(Edit Branch View): Allow deleting branch paths - Githubissues

WISE-Community / WISE-Client

Client-side code for WISE

Other

3 stars 4 forks source link

feat(Edit Branch View): Allow deleting branch paths #1930

Closed geoffreykwan closed 1 month ago

geoffreykwan commented 1 month ago

Changes

In the edit branch view you can now delete branch paths

Note: CreateBranchPathsComponent should probably also be changed to use a FormArray like EditBranchPathsComponent.

Things that still need to be handled properly

Deleting all paths
Deleting all but one path
Changing "How to Choose Among Paths", "Step", and "Component" has some bugs that still need to be worked on

Test

Make sure these actions work properly
- Delete one path and submit, it should move the path steps after the branch
- Delete multiple paths and submit, it should move the path steps after the branch
- Add a path and delete an existing path and submit, it should handle this properly

geoffreykwan commented 1 month ago

Ok, I've made the changes. I couldn't reproduce the jigsaw bug.