search

WISE-Developers / Project_issues

This handles incoming tickets like bugs and feature requests
GNU Affero General Public License v3.0
2 stars 0 forks source link

Protection of some C++ Code #128

Open spydmobile opened 2 years ago

spydmobile commented 2 years ago

There are obviously some areas of the source code we will want to preserve more than others, a good example is the currently accepted code for the FWI/FBP. Do we want to innovate this? Yes, but in a controlled fashion, so we would set up a code review standard that says, you may not alter the FWI/FBP code located at line xxx-yyy in file abc.h etc, than when automating pre pull request code review, we auto reject any submissions that do not respect these published and well documented standards. This is how we achive this without reverting to being source code Nazis.

spydmobile commented 2 years ago

@BadgerOnABike @nealmcloughlin @RobBryce I see this is a matter of policy and SOP rather than a technical problem. do you guys agree?

BadgerOnABike commented 2 years ago

Arguably CFFDRS will be properly opened soon enough (and already is in R, I'd like to get the C up too) as well, so folks can muck with whatever they decide it just wouldn't get pulled back in.

nealmcloughlin commented 2 years ago

I would agree that this is a policy for how we manage our open source code as opposed to a technical problem. The only hitch with this policy is if we did in fact have an error in our FWI/FBP code. This may not be a problem now but could become relevant if/when we migrate to next generation CFFDRS. Our code review policy would auto reject submissions that might be important for us to review.