WISE-Developers / Project_issues

This handles incoming tickets like bugs and feature requests
GNU Affero General Public License v3.0
2 stars 0 forks source link

[WISE FR]: Add flags to WISE executable for shared memory and CPU control - Extend to API and other ocmponents #155

Closed spydmobile closed 1 year ago

spydmobile commented 1 year ago

Contact Details

spydmobile@gmail.com

What is needed?

Add flags to the executable so that we can control shared memory options and CPU/Core management. This may resolve #154. This feature must be exposed to the APIs and other components that call the executable EG builder, and or Manager etc.

How will this improve the project or tool?

No response

Approvals Process

spydmobile commented 1 year ago

UPDATE: Ok, upon further discussions with Rob (And Travis by way of Rob), we know that:

only one edge case every needs shared memory: Running WISE + Prometheus on Windows (For which the command line flag can be used)

All other scenarios cannot use shared memory, therefore, I want we do as Rob has suggested:

Flip the bit - the flag enables instead of disables shared memory so the default is never use shared memory, this would resolve all issues except the rare edge case above.

By flipping the bit to default disabled, it means we do not have to modify the FGMJ structure or the Protobuf Structure. and therefore not create a bunch of wrk that needs testing or validation.

By doing this, we address #154 and #155 with the least amount of work, and least amount of change to the codebase

I will never need the flag, nor will HSS.