WISE-Developers / Project_issues

This handles incoming tickets like bugs and feature requests
GNU Affero General Public License v3.0
2 stars 0 forks source link

[TASK] Review of legacy functionality #64

Open RobBryce opened 2 years ago

RobBryce commented 2 years ago

This item is to serve as a place-holder to review legacy functionality from Prometheus that may or not be appropriate to keep in PSaaS. Examples:

  1. Judi Beck’s work defined diurnal curves through a day based on minimum and maximum wind speeds, temperatures, and RH. It’s possible that this work has no value in this modern tool, and this functionality could be ended in the V6 source tree. If so, then it can be removed, but also we have an opportunity to clean up the file format there, too. This could be included with work related to REDMine #1289.
  2. Also w/r to weather, while Judi Beck’s work may not be needed, all batch processing seems to work with standard noon readings. There actually isn’t a “mode” to define this, and rather, the client program needs to define an hourly weather stream with the same weather values for the duration of the burning period.
  3. The FGMJ has a lot of display properties that to date, it appears that all PSaaS uses do not need or use. These display properties, like colors of the ignition polygon, are useful for Prometheus.
  4. There are some non-standard experimental implementations for HFFMC that are referenced.
    • Kerry Anderson's Equilibrium model, and a hybrid model that tries to incorporate both Lawson and Van Wagner; and
    • smooth between the two when switching from one to another as precipitation disappears in recent data)

These are useful for experimental work, but not worth keeping if there is no need.

BadgerOnABike commented 2 years ago

Of note, we did discuss this at the CWFGF (Unified Framework Group) meeting and were of the opinion that some of this would be considered pre-processing and could be done by the framework API.

spydmobile commented 1 year ago

@nealmcloughlin please determine which of the above list needs to saty or go and assign back to rob please.