WISE-Developers / Project_issues

This handles incoming tickets like bugs and feature requests
GNU Affero General Public License v3.0
2 stars 0 forks source link

[TASK] Test if #35 (statistics retrieval for an individual fire point vertex) is working. #86

Open spydmobile opened 2 years ago

spydmobile commented 2 years ago

ref: #35 @RobBryce confirmed this is done, it just needs testing so assigning to @nealmcloughlin

spydmobile commented 2 years ago

@nealmcloughlin checking in if you can test this one

spydmobile commented 2 years ago

hi @nealmcloughlin please test this, thanks!

spydmobile commented 1 year ago

@RobBryce nobody can test this but you, please add it to you pile. Nobody has a clue what the error codes are or what they mean.

BadgerOnABike commented 1 year ago

Would you mind providing the method with which you generate these error codes as well. This will serve the purpose of learning how you are doing this testing as well as expanding our automatic testing into the future.

RobBryce commented 1 year ago

The code has been fixed. The situation where error codes could be generated shouldn't exist unless there is a programming error - which is intended to help find bugs moving ahead. This is far internal to any code that would see any form of automated testing.

BadgerOnABike commented 1 year ago

If this is to be tested in WISE, are we able to do it with the current JS API or does that need to be updated first?

@spydmobile

spydmobile commented 1 year ago

@BadgerOnABike I dont know. I am guess, there has been no change in the JS api for a while and we likely need to wait for a successful new build to find out. Am I out to lunch here @RobBryce ?

RobBryce commented 1 year ago

This code is so buried from any JS API call that (discussed before), there's no easy way for you to test other than to confirm that grid exports for simulation statistics look correct. The error condition shouldn't have occurred anyway, but this was done in the interests of keep the code clean, and to catch future bugs from future changes in the code.

spydmobile commented 1 year ago

thank but @RobBryce the question is, "Can we test this with the current JS API" or not?

RobBryce commented 1 year ago

Not directly.