search

WISPBill / WISPBill-Web-App

A Laravel App for running an ISP or WISP. It can do Billing, User Management, Monitoring, Provisioning and much more
GNU Affero General Public License v3.0
13 stars 13 forks source link

Feature settings #3

Closed tmcdon89 closed 8 years ago

tmcdon89 commented 8 years ago

I think it would be handy to add some features for radius integrations as well as provisioning etc ... Once the core is built up. Do you have a preference on making a settings table or config files?

turtles2 commented 8 years ago

The last version I used a config file but I felt that was sloppy. I am thinking a table would be cleaner and make managing easier. What do you think?

tmcdon89 commented 8 years ago

My preference would be a settings table. Then new settings for a feature can be added to the table with a simple migration file at that point. It makes for a robust clean setup in my opinion. The table could be as simple as -setting name -default value -current value

tmcdon89 commented 8 years ago

Being in a table gives the additional benefit of easily turning settings and features on or off from within the app.

turtles2 commented 8 years ago

I agree that would be the best way. I believe this is resolved so I am going to close it.

turtles2 commented 8 years ago

I did't see a use for a default value. So I left it out.

tmcdon89 commented 8 years ago

The only reason for a default value would be so the user could set something back to a value that "should" work. It just shows them what they changed. It's definitely not necessary in the context of a true use. Mostly just a reference. But we could easily document what the default values are in a seed file or the wiki.