search

WISPO-POP / PowerPlots.jl

Functions plot PowerModels networks
BSD 3-Clause "New" or "Revised" License
22 stars 2 forks source link

Julia-only Kamada Kawai Capability #29

Closed j-gorka closed 3 years ago

j-gorka commented 3 years ago

KK implementation added. PyCall imports still present but not used.

codecov-io commented 3 years ago

Codecov Report

Merging #29 (8cb9821) into dev (fdbcdb6) will increase coverage by 1.98%. The diff coverage is 87.34%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev      #29      +/-   ##
==========================================
+ Coverage   81.83%   83.82%   +1.98%     
==========================================
  Files          15       16       +1     
  Lines         534      649     +115     
==========================================
+ Hits          437      544     +107     
- Misses         97      105       +8
Impacted Files Coverage Δ
src/core/options.jl 100.00% <ø> (+50.00%) :arrow_up:
src/PowerPlots.jl 50.00% <16.66%> (-50.00%) :arrow_down:
src/plots/power_vega.jl 86.02% <84.70%> (+3.05%) :arrow_up:
src/plots/kamada_kawai.jl 94.73% <94.73%> (ø)
src/core/data.jl 70.45% <100.00%> (+9.34%) :arrow_up:
src/core/export.jl 100.00% <100.00%> (ø)
src/core/utils.jl 96.87% <100.00%> (+3.32%) :arrow_up:
src/layouts/layout_engines.jl 55.55% <100.00%> (ø)
src/plots/networks.jl 64.44% <100.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fdbcdb6...8cb9821. Read the comment docs.

noahrhodes commented 3 years ago

The CI failures seem to be that the old power_plot() function is trying to use kamada kawaii and something is going wrong. Those don't necessarily need to run on this, but if its not much work to fix, but it would be useful to have while the transition is still happening.