Closed noahrhodes closed 2 years ago
Merging #74 (f8f0330) into master (ca1b463) will decrease coverage by
19.13%
. The diff coverage is0.00%
.
@@ Coverage Diff @@
## master #74 +/- ##
===========================================
- Coverage 92.35% 73.21% -19.14%
===========================================
Files 11 10 -1
Lines 340 407 +67
===========================================
- Hits 314 298 -16
- Misses 26 109 +83
Impacted Files | Coverage Δ | |
---|---|---|
src/layouts/layout_engines.jl | 38.68% <0.00%> (-55.96%) |
:arrow_down: |
src/core/configuration.jl | 77.77% <0.00%> (-11.12%) |
:arrow_down: |
src/core/utils.jl | 88.46% <0.00%> (-5.48%) |
:arrow_down: |
src/core/export.jl |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update ca1b463...f8f0330. Read the comment docs.
Best option to to correctly pre-allocate arrays and @simd matrix operations.
Using advanced options like LoopVectorization or Tullio are faster but introduce a significant compilation latency. This could be explored in the future if the functions can be precompiled.
add type annotations, preallocated arrays, and broadcasted operators to speed up the kamada kawaii layout.
Laptop Results:Not up to dateDesktop Results:
~~Changing from OMEinsum to Tullio allows preallocate the gradient calculation array. Allocations now decreased by ~5x. Also has a speed up of of 2x. ~~
case500 is a bizzare outlier. I cannot understand why it runs slower.Removed Tullio, just wrote nested for loops with LoopVectorization. Increase speedup by an additional 2x.
First time to run is much improved, about 7xFirst time to run is less improved, 2x speedup instead of 7x.First time to run is now even worse: