keatsig commented 3 years ago

This PR modifies data dictionary for unbalanced distribution grid cases (supports openDSS files parsed by PowerModelsDistribution.jl) to account for the three-phase parameters.

codecov-commenter commented 3 years ago

Codecov Report

Merging #75 (928a19a) into master (39260de) will increase coverage by 0.16%. The diff coverage is 87.50%.

@@            Coverage Diff             @@
##           master      #75      +/-   ##
==========================================
+ Coverage   88.26%   88.43%   +0.16%     
==========================================
  Files          12       13       +1     
  Lines         537      588      +51     
==========================================
+ Hits          474      520      +46     
- Misses         63       68       +5

Impacted Files	Coverage Δ
src/PowerPlots.jl	`100.00% <ø> (ø)`
src/plots/plot_processing.jl	`86.95% <86.95%> (ø)`
src/plots/plot.jl	`58.75% <100.00%> (+1.05%)`	:arrow_up:
src/layouts/SFDP_fixed_layout.jl	`94.52% <0.00%> (-1.37%)`	:arrow_down:
src/core/export.jl	`100.00% <0.00%> (ø)`
src/core/utils.jl	`97.43% <0.00%> (+2.84%)`	:arrow_up:
src/core/configuration.jl	`100.00% <0.00%> (+11.11%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 39260de...928a19a. Read the comment docs.

noahrhodes commented 2 years ago

Is PMD required as a dependency? (are any PMD functions called by Power Plots?). This can make a big difference in allowing parallel precompilation of PowerPlots and PMD when updating the packages.

noahrhodes commented 2 years ago

TODO:

[ ] Update Changelog
[x] Update documentation

noahrhodes commented 2 years ago

@keatsig I updated the changelog. I this ready to merge?

keatsig commented 2 years ago

Yes, it is ready to merge.

From: noahrhodes @.> Sent: Friday, January 7, 2022 12:44 PM To: WISPO-POP/PowerPlots.jl @.> Cc: KSHITIJ I GIRIGOUDAR @.>; Mention @.> Subject: Re: [WISPO-POP/PowerPlots.jl] FIX: data dictionary for distribution grids (#75)

@keatsighttps://github.com/keatsig I updated the changelog. I this ready to merge?

— Reply to this email directly, view it on GitHubhttps://github.com/WISPO-POP/PowerPlots.jl/pull/75#issuecomment-1007647107, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AKHNRKSQF6W5UCPA5MBLQVDUU4X7BANCNFSM5CELL43A. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you were mentioned.Message ID: @.***>

WISPO-POP / PowerPlots.jl

FIX: data dictionary for distribution grids #75

Codecov Report