WISVCH / dienst2

CH Dienstensysteem: administratie van leden en post
https://dienst2.ch.tudelft.nl
Other
4 stars 2 forks source link

GitHub Actions: Only login to Docker registry when pushing #293

Closed praseodym closed 2 years ago

praseodym commented 2 years ago

The GitHub Actions deploy workflow tries to log in to the Docker registry (Quay) even when nothing will be pushed to the registry, i.e. when checking a pull request. This breaks Dependabot PR builds (e.g. #279, #282, #292) because those do not have access to secrets.

https://github.com/WISVCH/dienst2/blob/76b163a208c327f6446181995e911cc052501394/.github/workflows/deploy.yml#L57-L62