WISVCH / events

Registration for CH events (lectures, workshops, excursions, ...)
https://ch.tudelft.nl/events/
7 stars 10 forks source link

External product url #430

Closed robertdijk closed 1 year ago

robertdijk commented 1 year ago

This PR adds the option to add a URL instead of products to an Event. Using this you can have your event in events but have the registration somewhere else.

robertdijk commented 1 year ago

This is how I made it work now:

I do have 2 questions (@WISVCH/beheer)

robertdijk commented 1 year ago
Scherm­afbeelding 2023-04-18 om 19 40 29

This is how the homepage looks with an event with an external URL. The description is now used as a text in the box. This could be a problem since the texts used could be very long.

Another option could be just having the button, like this:

Scherm­afbeelding 2023-04-18 om 19 45 37

I think that option is nicer. @julian9499 What do you think?

JoepdeJong commented 1 year ago

Personally I prefer the first one, but I think it does not really matter. If we want a better looking events page, we just have to redesign is. Both are fine by me.

robertdijk commented 1 year ago

Personally I prefer the first one, but I think it does not really matter. If we want a better looking events page, we just have to redesign is. Both are fine by me.

Yea the problem is, is that when the description gets long, this happens.

Scherm­afbeelding 2023-04-19 om 09 36 55
JoepdeJong commented 1 year ago

Yea the problem is, is that when the description gets long, this happens.

hmm, can't we just keep these descriptions short? or is this the general description of the event? What if you place a shorter version of the description after the i:

Screenshot 2023-04-19 at 10 02 47
robertdijk commented 1 year ago

The Description is the one that is synced to the calendar, so I don't think we have an influence on the length.

JoepdeJong commented 1 year ago

The Description is the one that is synced to the calendar, so I don't think we have an influence on the length.

Maybe I do not understand the problem. You want to show an additional description when tickets are sold externally? Or do you just want to fill up the space?

robertdijk commented 1 year ago

The Description is the one that is synced to the calendar, so I don't think we have an influence on the length.

Maybe I do not understand the problem. You want to show an additional description when tickets are sold externally? Or do you just want to fill up the space?

I just wanted to fill up the space with possibly useful information. But I think it's best to keep it empty. If someone wants more information there, then can add it to the short description, which will automatically use up that space.

robertdijk commented 1 year ago

Great, then i think with this look, it is ready!

Scherm­afbeelding 2023-04-19 om 10 28 33