search

WISVCH / events

Registration for CH events (lectures, workshops, excursions, ...)
https://ch.tudelft.nl/events/
7 stars 10 forks source link

WIP: Implement parent products #505

Closed JoepdeJong closed 1 month ago

JoepdeJong commented 1 month ago

This PR allows for sharing stock between products inside an event, by linking the products to a parent product.

TODOs

robertdijk commented 1 month ago

I think the max amount of tickets is now not enforced for the group. So the if the parent has max tickets allowed per user on 1, I can buy one of the parent, and one of the child. Is this the desired behaviour? If so, I think it should not be inherited, but individually configurable per product. Or it should be enforced.

JoepdeJong commented 1 month ago

I think the max amount of tickets is now not enforced for the group. So the if the parent has max tickets allowed per user on 1, I can buy one of the parent, and one of the child. Is this the desired behaviour? If so, I think it should not be inherited, but individually configurable per product. Or it should be enforced.

it is easier to not inherit it, but i am not sure what is desired.. it is only to share availability between certain products in an event. i will ask the board to comment

julian9499 commented 1 month ago

@JoepdeJong Should this PR include a migration? If i remember my hibernation knowledge correctly you are adding columns to an existing table. The older products need to have a default value right?

robertdijk commented 1 month ago

it is easier to not inherit it, but i am not sure what is desired.. it is only to share availability between certain products in an event. i will ask the board to comment

I added a PR to add this functionality! #506

JoepdeJong commented 1 month ago

@JoepdeJong Should this PR include a migration? If i remember my hibernation knowledge correctly you are adding columns to an existing table. The older products need to have a default value right?

Fixed!