search

WISVCH / events

Registration for CH events (lectures, workshops, excursions, ...)
https://ch.tudelft.nl/events/
7 stars 10 forks source link

Wallet: Remove the requirement to be authenticated, add fallback when no location is set #507

Closed dsluijk closed 1 month ago

dsluijk commented 1 month ago

People are running into a generic error when trying to add a ticket to their {Apple, Google} Wallet. Since the ticket key is sufficiently random, we can just remove the requirement to be authenticated.

Secondly for the Google Wallet we get an error when no location is set for a ticket. This also adds a fallback location (Unknown), so it still proceeds.

JoepdeJong commented 1 month ago

@dsluijk i just noticed, as authenticationService is not required anymore, it can be removed from the initializer of the WebshopPassesController. can you look at this?

dsluijk commented 1 month ago

I believe this is still required for other subclasses of the WebshopController superclass. So I don't think we can do that.