search

WISVCH / feedback

CH FeedbackTool
0 stars 2 forks source link

Email encryption #24

Open svenpopping opened 5 years ago

svenpopping commented 5 years ago

Requested by the TU Delft

This PR contains the encryption and decryption of the name and email of the employees of the TU Delft. The crypto scheme uses AES/CBC/PKCS5Padding encryption with a fixed IV.

A fixed IV is used to make the implementation a lot easier otherwise the IV should be stored somewhere which makes the encryption and decryption a lot harder/messier.

praseodym commented 5 years ago

Reusing the IV makes the encryption scheme completely insecure.

More importantly, I'm wondering about the threat model here: what threat is mitigated by implementing this encryption scheme (provided it were properly implemented)?

svenpopping commented 5 years ago

Using a fixed IV is not completely insecure. CBC with a fixed IV is IND-PASS secure, meaning that the system is secure if an advantage is “small” for all polynomial-time adversaries A.

Threat model If there is an (accidental) database breach that the adversary does not have a list of TU Delft employees email addresses in plaintext. Increasing the number of steps the adversary has to make to obtain the email addresses and thus improving security.

praseodym commented 5 years ago

Adding IND-PASS security to some columns of the database, while not reviewing a wider threat model just doesn’t make sense.

As for this concrete case, TU Delft employee names and email addresses are public information (e.g. through the find employees page and course browser) which makes this PR even more debatable.

svenpopping commented 5 years ago

As for this concrete case, TU Delft employee names and email addresses are public information (e.g. through the find employees page and course browser) which makes this PR even more debatable.

The TU does not allow us to store this information without it being encrypted, so there is not much to discuss if we should do it or not. It is a requirement by the TU.

svenpopping commented 5 years ago

Implemented random IV to improve security

Fastjur commented 5 years ago

To add to the threat model. In case of a data breach, the TU wants the feedback to be connected to an encrypted name/email of said staff member. Don't ask me why...

svenpopping commented 4 years ago

Is this still relevant?

Fastjur commented 4 years ago

I would assume it still is. The TU still would only allow us to use the feedback tool if it is encrypted. So I am assuming we still need this.

Fastjur commented 4 years ago

I resolved the conflicts using the web editor, they were only imports.