search

WISVCH / florriebot

Florrie bot <3
1 stars 6 forks source link

Decaffeinate all script files #113

Closed TimvdLippe closed 6 years ago

TimvdLippe commented 7 years ago

Since ES6 landed, most of the coffeescript special syntax is incorporated in EcmaScript itself. Using ES6, contributing to this project becomes easier, as ES6 is more well-known than coffeescript.

I have tested this PR with several files and everything appears to be working. There was no test suite available, so I am not 100% sure if this is actually the case :wink:

praseodym commented 7 years ago

Does ES6 work on Node.js 4.8.2?

TimvdLippe commented 7 years ago

Ah, per http://node.green/ that appears to be (probably) true. Not sure how to test it, as I am running the latest version of Node :stuck_out_tongue:

praseodym commented 7 years ago

Try the Dockerfile 😉

Feel free to update the Dockerfile as needed. The only requirement we have is that the CH CA must be trusted by Node.

TimvdLippe commented 7 years ago

@praseodym All right, done! I tested by building the Docker image and then run docker run -it --rm <version> bash and in there run florrie /r/programmerhumor and it worked :smile:

praseodym commented 7 years ago

I think we might be better off basing the Dockerfile on node:carbon and then adding the CA certificate. Either way, node will need to be started with --use-openssl-ca.

TimvdLippe commented 7 years ago

@praseodym Done! Based of node:8 per https://github.com/nodejs/docker-node

praseodym commented 7 years ago

I think we're still stuck with Node not accepting the CH CA?

TimvdLippe commented 7 years ago

I copied the content of https://github.com/WISVCH/docker-debian/blob/master/stretch/Dockerfile so I am not sure what else needs to be done to fix it?

praseodym commented 7 years ago

Either way, node will need to be started with --use-openssl-ca.

TimvdLippe commented 7 years ago

Well, that was "fun". All dependencies are now decaffeinated as well. I had to point to the github repos though, as most of the packages are not published. Will create PRs for all of them.

TimvdLippe commented 6 years ago

All packages that have been deprecated are removed. This PR is now only blocked on https://github.com/jabbink/hubot-plusplus-improved/pull/1 Other than that this is ready for review!

jabbink commented 6 years ago

Okay, I'll look at it this weekend. Pinky promise.

TimvdLippe commented 6 years ago

This PR is now ready for review/merge