search

WJunHong / pe

0 stars 0 forks source link

Separation of editing commands #11

Open WJunHong opened 2 years ago

WJunHong commented 2 years ago

The 2 edit commands should not be separate as editing the social media is impossible via the first command when it is displayed to be editable. Seems like it is only 1 command with edit keyword

Screenshot 2022-04-16 at 3.12.35 PM.png

soc-pe-bot commented 2 years ago

Team's Response

Accepted as a bug.

Marked as duplicate to #1731 because this discrepancy was introduced in the last minute by PR 260, causing editing social media using the command in section 4.1 of the UG to not be possible.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Cannot edit existing social media

Steps to reproduce:

  1. Have person with any social media already present
  2. attempt edit IINDEX sm/gmail, black

Expected: Successful update based on what the UG stated.

Actual: Unable to update social media. Screenshot 2022-04-16 at 3.07.19 PM.png

[original: nus-cs2103-AY2122S2/pe-interim#1744] [original labels: type.FunctionalityBug severity.Medium]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Accepted. However, this bug should have a low severity because the user can edit the social media once the index is specified, as shown in the UG screenshot:

image.png

Scenarios where the user needs to replace a person's social media list are very rare.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

:question: Issue type

Team chose [type.FunctionalityBug] Originally [type.DocumentationBug]

Reason for disagreement: [replace this with your explanation]