WJunHong / pe

0 stars 0 forks source link

Valid phone number #2

Open WJunHong opened 2 years ago

WJunHong commented 2 years ago

Steps to reproduce:

  1. enter add n/goutham p/9188 4836 e/junhong@gmail.com sm/whatsapp, boi into command box

Expected result: Application allows for the addition since 9188 4836 is a valid phone number

Actual result: Formatting error is displayed. Not shown in the UG that phone numbers must be contiguous without spacing. Screenshot 2022-04-16 at 2.21.32 PM.png

nus-pe-script commented 2 years ago

Team's Response

Phone number only accepts numeric characters, a whitespace is not numeric.

9188 4836 is a valid phone number, but the user can just remove the whitespace in the middle to form 91884836 (it's the same number) to be accepted as numeric.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [I feel that this is a valid case of overzealous input validation as using spaces like this is quite common when people type in phone numbers. The team should have at least tried to throw a warning, or simply remove any whitespace between numbers, which would have allowed the user to continue using the app without many problems.]


:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: [replace this with your explanation]