WKHarmon / led-sectional

MIT License
35 stars 20 forks source link

Nothing for LTG DSNT #22

Open jcl-rv12is opened 1 year ago

jcl-rv12is commented 1 year ago

Nice project!

I did notice that the field appears to be ignored, which is where things like "LTG" or "LTNG" appear. Thus, unless I'm missing it, there will only be blinking for "lightning" if the string "TS" is in the field. Is checking something that can be added? I've got plenty of airports today showing LTG DSNT but no thunderstorms.

Thanks!

WKHarmon commented 1 year ago

Hola!

That's a good point, but my inclination is to leave it as is by default. Including LTG DSNT would probably make large swaths of the map start blinking even when a thunderstorm isn't particularly close. If you wanted to add it, though, it would probably be pretty simple. I created a new branch that checks for LTG in the raw_text field here:

https://github.com/WKHarmon/led-sectional/blob/ltg_check/led-sectional.ino

I haven't actually tested it, so let me know if it doesn't work.

jcl-rv12is commented 1 year ago

Hola!

That's a good point, but my inclination is to leave it as is by default. Including LTG DSNT would probably make large swaths of the map start blinking even when a thunderstorm isn't particularly close. If you wanted to add it, though, it would probably be pretty simple. I created a new branch that checks for LTG in the raw_text field here:

https://github.com/WKHarmon/led-sectional/blob/ltg_check/led-sectional.ino

I haven't actually tested it, so let me know if it doesn't work.

I added a fork that makes that change, and a change to blink orange for high winds/gusts for all flight categories vs solid orange only for VFR airports.

WKHarmon commented 1 year ago

Nice. I see that you also implemented WiFiManager, which is something that I've been meaning to do for a while.