nus-se-bot
commented
3 years ago Team's Response
Thank you for the bug report.
Firstly, this issue will only occur on the rare instance that someone undoes a macro command that has an error. Since this will very unlikely affect the normal operation of the app, we will label the severity as "Low" instead of "High". Refer to image below:
Secondly, we will also be rejecting this as a bug as it is actually according to the expected behaviour.
From the UG,
The 'previous command' here would be the command in line 1, since the second one had an error.
Undo has undone the creation of AddWith100carbs (in line 1), therefore you can create it again without any error thrown.
Thus, we will lower the severity and reject the bug.
Items for the Tester to Verify
:question: Issue response
Team chose [response.Rejected]
- [x] I disagree
Reason for disagreement: I disagree with the team's response since the 'undo' behavior is actually inconsistent. The team says " The ‘previous command’ here would be the command in line 1, since the second one had an error." but however, in my another bug report that is accepted, regarding undo and export, if the first export command is correct but second is wrong(the second one does not export the file and shows an error message), then use undo, undo will not change anything and did not undo the first command, and hence did not undo the "first command since second one has an error." I think that this is inconsistent behavior, and could not be sufficiently justified by the explanation given, since in some case, the error command is indeed treated as the "previous command", but in some case it is not.
Moreover, it is not specified in UG clearly that "For applying undo on adding macro, the previous command for macro would be the last correct command, if the latest command for macro had an error" . Thus I consider this as a bug that should not be rejected since this behavior is not specified in User Guide as well, as the screenshot below is all the explanation on undo(not including annotated screenshot):
Thus, I consider this as "behavior not specified" and hence a functionality bug. Although using undo after an error command may not happen frequently, I think that this inconsistency is still a bug to be addressed, and inconveniences that happen sometimes could be classfied under a low severity bug.
:question: Issue severity
Team chose [severity.Low]
Originally [severity.High]
- [ ] I disagree
Reason for disagreement: [replace this with your explanation]
Input: macro AddWith100carbs p ; add -n \$ -c 100 -p \p macro AddWith100carbs p ; add -n \$ -c 100 -p \p ->repetition error shown undo macro AddWith100carbs p ; add -n \$ -c 100 -p \p -> this will add the macro again
But undo should do nothing since repetition error shown for the previous command