search

WMCAlliance / BukkitIRCd

BukkitIRCd was an IRC bridge plugin for Minecraft servers running Bukkit. It creates individual 'bot' users for every player to allow seamless communication.
https://wma.im
Other
5 stars 6 forks source link

Staff channel messages are limited to 299 characters (!pl is a good example) #37

Open WizardCM opened 11 years ago

WizardCM commented 11 years ago

In minecraft-staff, the response from a command is limited to 299 characters, as shown below.

Should be;

Plugins (68): W4, Privileges, MiniFixes, Memory, CommandViewer, WMABroadcast, RoyalDeath, Vault, Multiverse-Core, uSkyBlock, DevJoined, dynmap, BukkitIRCd, SurvivalGames, SpongeRecipe, Duties, TNTSweeper, ProtocolLib, ConnectFour, MobArena, CleanroomGenerator, Plotty, LagMeter, ZeeSlag, Shortify, WorldEdit, NoCheatPlus, Multiverse-Inventories, CreativeGates, MultiMapsFix, TagAPI, Multiverse-NetherPortals, VanishNoPacket, DeathControl, MCdigr, War, StandardBooks, NCore, Paintball, WorldGuard, TF2, Tetris, SignEdit, ImgMap, MineJong, NBTEdit, UltimateSkyGrid, MonsterMOTD, CommandHelper, AnimalProtect, AntiXRay, The Trashcan, Lockette, NoNewChunk, FirstJoinPlus, ButtonWarp, MobHealth, WorldBorder, Multiverse-Portals, ScriptBlock, Dynmap-WorldGuard, DisguiseCraft, NTheEndAgain, HawkEye, RoyalCommands, ChessCraft, NameTags, LimitedWorldEdit, RoyalChat

Comes through;

Plugins (68): W4, Privileges, MiniFixes, Memory, CommandViewer, WMABroadcast, RoyalDeath, Vault, Multiverse-Core, uSkyBlock, DevJoined, dynmap, BukkitIRCd, SurvivalGames, SpongeRecipe, Duties, TNTSweeper, ProtocolLib, ConnectFour, MobArena, CleanroomGenerator, Plotty, LagMeter, ZeeSlag, Shortify,

chyyran commented 11 years ago

This might be a problem with IRC rather than the plugin. Not 100% sure though

WizardCM commented 11 years ago

If that turns out to be the case, there are two things we could do here; A) detect the length then split the message so the whole thing is sent Or B) if the whole message doesn't come through, the next message should say something like "The response to your command was longer than we could send. Please try this ingame or from console instead." In red.

chyyran commented 11 years ago

According to http://www.networksorcery.com/enp/protocol/irc.htm , the max message length for IRC is 512 characters including leading/trailing CRLF, and the protocol message (PRIVMSG and all that). So I think it might be a problem of the IRC protocol

WizardCM commented 10 years ago

This has been (at least partly) improved in ttps://github.com/WMCAlliance/BukkitIRCd/commit/43700b3d3a5e4a6c7b166f3e8c32ec41a083f69c - the messages are now split when sent to avoid loss of information. I don't know if colour codes are counted in the IRC protocol (I haven't checked) but in my current method - they are.