search

WMCAlliance / BukkitIRCd

BukkitIRCd was an IRC bridge plugin for Minecraft servers running Bukkit. It creates individual 'bot' users for every player to allow seamless communication.
https://wma.im
Other
5 stars 6 forks source link

Kicking a player from IRC doesn't show anything ingame #72

Closed WizardCM closed 11 years ago

WizardCM commented 11 years ago

There are two ways we could go about this;

  1. Display a custom kick message ingame, based on messages,yml
  2. Using the kick-commands option in config.yml, kick the player using that command instead of whatever we're doing now - however, would we then be able to show a custom user name?

I'm leaning towards 2 more, but 1 might be easier and faster as a quick-fix.

chyyran commented 11 years ago

I think 1 would be the better way to do it.

void kickIngamePlayer(Player player, String reason, String kicker){
    player.kickPlayer("Kicked IRC by " + kicker + ": " + reason);
    Bukkit.getServer().broadcastMessage(player.getDisplayName() + "was kicked by " + kicker ": " +reason);
}
WizardCM commented 11 years ago

This is partly fixed, but is not yet configurable.

WizardCM commented 11 years ago

As it turns out, this was already implemented, but not working properly. in https://github.com/WMCAlliance/BukkitIRCd/commit/dbec19474b4bb746072f21486336777c0f2ee3bd @glguy fixed the issue.