search

WMEValidator / validator

WME Validator Source Files
GNU General Public License v3.0
11 stars 10 forks source link

Adding configuration and new checks #73

Closed davidakachaos closed 5 years ago

davidakachaos commented 5 years ago

Added some new checks and a configuration option. Sorry for not splitting this up correctly, if you want I could try to break this apart.

berestovskyy commented 5 years ago

Looks good. Do not need to squash yet, we will squash on merge to the master.

I will test the dev branch during the weekend. Maybe we should ask for some volunteers on the forum to test this branch and provide a feedback as well?

davidakachaos commented 5 years ago

Okay, we will merge and do a test. Maybe we should put up a test version pre build somewhere, easier for people to test that do not know (or want) how to build. We could put the script unlisted on GreasyFork and link it on the forum for people to test. If we do that, we can ask people to test the new functions on the forum, discord, slack etc...

berestovskyy commented 5 years ago

Would you like to lead this beta branch?

davidakachaos commented 5 years ago

Sorry, had my kids over the weekend so was offline for most of it 😉 I'm willing to help out anyway I can, so yeah, I'll set something up so we can spread it around.

davidakachaos commented 5 years ago

@berestovskyy I've created a beta version of the script and put it on GreasyFork as unlisted here

I want to link it on the forum as a test version using the following text:

Hello everyone! We've created a test version of WME Validator with support for checking venues beside segments. We want to test this out and see if everything works correctly. We've some new checks specially for venues. We would love to hear your feedback on this either here on the forum or via the Github issues! If you're willing to test this version out, please install the beta version of this script via this link (be sure to disable the current install of WME Validator!)

This could be posted to the discord too. Would this be okay?

berestovskyy commented 5 years ago

Sorry, I just realized I have added the beta tag to the main version of Validator :) To avoid confusions, maybe let's call it alpha, experimental, release candidate (RC), daily build, or anything different than beta?

And it would be nice if I or potentially other developers could update this experimental branch as well. I just googled if it's possible to share a script on GF, but it seems not: https://github.com/JasonBarnabe/greasyfork/issues/311

Maybe we better create a repo similar to release: https://github.com/WMEValidator/release

So we have a bit more flexibility with access permissions. What do you think?

justins83 commented 5 years ago

You can sync a github repository to a greasyfork script via webhook, therefore not needing to share the greasyfork credentials. This is the simplest way to do it and what we have done in the WazeDev group

On Mon, Oct 15, 2018 at 12:14 PM Andriy Berestovskyy < notifications@github.com> wrote:

Sorry, I just realized I have added the beta tag to the main version of Validator :) To avoid confusions, maybe let's call it alpha, experimental, release candidate (RC), daily build, or anything different than beta?

And it would be nice if I or potentially other developers could update this experimental branch as well. I just googled if it's possible to share a script on GF, but it seems not: JasonBarnabe/greasyfork#311 https://github.com/JasonBarnabe/greasyfork/issues/311

Maybe we better create a repo similar to release: https://github.com/WMEValidator/release

So we have a bit more flexibility with access permissions. What do you think?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/WMEValidator/validator/pull/73#issuecomment-429917523, or mute the thread https://github.com/notifications/unsubscribe-auth/ATTy2vcXCiU8g6NsnyUQGzt0AAmiSzwNks5ulLRGgaJpZM4XMedV .

-- JustinS83 USA Local Champ

davidakachaos commented 5 years ago

@berestovskyy I'll rename it to alpha then :smile: And I agree, it would be nice to have. @justins83 We have a build script that needs to be run before we publish. Maybe we need to look into a auto build service? And publish from there?

justins83 commented 5 years ago

Yes, I understand how the build process works. It should be trivial to add to the build script to commit the changes to github once complete, which would then trigger the webhook and posting to greasyfork.

On Mon, Oct 15, 2018 at 7:25 PM David Westerink notifications@github.com wrote:

@berestovskyy https://github.com/berestovskyy I'll rename it to alpha then 😄 And I agree, it would be nice to have. @justins83 https://github.com/justins83 We have a build script that needs to be run before we publish. Maybe we need to look into a auto build service? And publish from there?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/WMEValidator/validator/pull/73#issuecomment-430048351, or mute the thread https://github.com/notifications/unsubscribe-auth/ATTy2oxV_53ILrycFLyTVTg0r0bcIvDuks5ulRmEgaJpZM4XMedV .

-- JustinS83 USA Local Champ

berestovskyy commented 5 years ago

IMO a webhook or an automatic sync does not change the fact that we need a shared account on GreasyFork, or do I miss something?

justins83 commented 5 years ago

You can certainly set up an account and share the credentials, but how many greasyfork scripts do you really need to set up? Production, beta and maybe alpha? Once those are set up and the webhooks established why would someone need continued access to the account?

On Tue, Oct 16, 2018 at 1:39 AM Andriy Berestovskyy < notifications@github.com> wrote:

IMO a webhook or an automatic sync does not change the fact that we need a shared account on GreasyFork, or do I miss something?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/WMEValidator/validator/pull/73#issuecomment-430107549, or mute the thread https://github.com/notifications/unsubscribe-auth/ATTy2vUD18Tf33sfD7ZP3XqrMXoA4XYIks5ulXEYgaJpZM4XMedV .

-- JustinS83 USA Local Champ

berestovskyy commented 5 years ago

Still, someone has to have an access... Anyway, seems David has decided to post the script under his account, so it does not matter anymore ;)

davidakachaos commented 5 years ago

I would be a better way to do it, but I wanted to start testing things out soon. Sorry if I made a mistake in that :-/

berestovskyy commented 5 years ago

It's ok with me. We can always create another GitHub repo or a shared account on GreasyFork...