search

WNC12k / DoomRPG-Rebalance

Doom RPG is an RPG Modification for the GZDoom Source Port
72 stars 16 forks source link

Multiplayer game: sell/store items when interacting with Mission BBS and Assembling machine with Pandemonia #240

Open Demiosis opened 2 years ago

Demiosis commented 2 years ago

Version : 2022-09-18

Using the mission BBS or Assembling machine in multiplayer will sometimes also activate the shop (The menu wont show) for some reason and either sell or store the items you currently own...

(using shift + d on BBS sold my friend's BFG and Chaingun and for me shift + d again on BBS sold my uzi and blaster..)

Not 100% sure it have anything to do with Pandemonia though it may be an issue with multiplayer to begin with.

I used this setup: (.bat)

"GZDOOM.exe" -host 2 -warp 01 -skill 2 -netmode 0 -extratic +sv_cheats 1 +playerclass Scout -file "map.wad" "DOOMMETALMODIFIED.wad" "sound.pk3" "DoomRL_Arsenal_1.1.5.pk3" "Pandemonia-v2.2-Monsters.pk3" DoomRPG DoomRPG-RLArsenal DoomRPG-PandemoniaMonsters Doomrpg-BrightMaps

The client's setup:

"GZDOOM.exe" -join xx.xxx.xx.xxx +playerclass Demolitionist -file "map.wad" "DOOMMETALMODIFIED.wad" "sound.pk3" "DoomRL_Arsenal_1.1.5.pk3" "Pandemonia-v2.2-Monsters.pk3" DoomRPG DoomRPG-RLArsenal DoomRPG-PandemoniaMonsters Doomrpg-BrightMaps

here is my config file for Gzdoom:

gzdoom-player.zip

WNC12k commented 1 year ago

I need to test it myself to have an idea how to fix it. In any case, if you have more information, please share it.

Demiosis commented 1 year ago

What else would you need? I'll try to be as specific as I can!

WNC12k commented 1 year ago

I mean, if you manage to find an algorithm where this happens, let me know.

Demiosis commented 1 year ago

an algorithm where this happens <---- Errr im not too sure what you mean ..

(I updated my 1st post with the client's .bat setup as well.. really dunno what else i could do.. ^^')

WNC12k commented 1 year ago

you say it happens sometimes. therefore, a certain set of actions in the game leads to this. so if it is possible to determine which set of actions in the game leads to this - let me know

Demiosis commented 1 year ago

Ho, well in that case , what I explained in my 1st post you should coax it to happen easily.. We were TWO players that had the issue in one trip to the outpost. On top of it happening once to my friend the trip before that. (Cheated in the missing weapons the 1st time with the console) so its very easy to make happen I should've not putted sometimes in my post... It make you assume its hard to do.. XD We even stopped multi because it make it quite annoying since its that easy to pull off.. save0.zip

Here is our save too? I really dunno what else I can give you now.. Like it should be a perfect copy pasta of our multi session at this point along with the 1st post..

Also this bug will most likely happen only in multiplayer since i used that same setup in single and didn't had that issue.. (minus multi/server reqs ofc)

Update: I remember that its when a player interact with the facilities delete the OTHER'S player weapons (also it did not happened with anything else than weapons)

Demiosis commented 1 year ago

Update : Tried with 3 friends , had this bug happen when the 3 of us we're browsing the skills one bought the enviro shield skill and me and another friend had some of our weapon sold! (it even happened when we had the shop option set to locker)

its probably when multiples peoples interact with any drpg options or facilities then some kind of desync happen..

Another update: a sure fire way to reproduce it: if any player have their menu open (stats/skills/aug menu), then if the 2 other players hold shift and have a shotgun or rifle or chaingun in their weapons and it will sell all weapons from a player(sometimes the pistol does not get sold) (The run key make it happen, be it bound to anything)

WNC12k commented 1 year ago

Thank you for the additional information. I will definitely come back to this when I have time

WNC12k commented 1 year ago

It looks like I managed to find the reason for it. The part when to control from zscript intended only for singleplayer was used in multiplayer. This is most likely what causes this bug. Update: https://github.com/WNC12k/DoomRPG-Rebalance/commit/ef08cd3bf368d2b424931fb31a18041a51d49eb0

But I'm not 100% sure, so I leave this issue open.

Please run tests and give feedback.

Demiosis commented 1 year ago

it will take quite a while before I get a test in sadly, not been playing doom for a while..

Someone65 commented 1 year ago

Will test soon after me and my friend finish our regular Doom 1 + RLA Extended playthrough. We're doing that to test for desyncs first (one has happened already) before we play DRPG otherwise we won't know what to blame for desyncs and might end up making false reports.