NPP, TG4NP, EU-logos in design - Githubissues

WNRI / route.is

Source code for the hiking information service route.is.

route.is

GNU General Public License v3.0

1 stars 2 forks source link

NPP, TG4NP, EU-logos in design #49

Closed dittaeva closed 11 years ago

dittaeva commented 12 years ago

Need to display the following in the header:

TG4NP logo (could perhaps be left out, if necessary)
NPP logo and EU flag + reference to European Union

The TG4NP logo will be uploaded to the repository.

esisa commented 11 years ago

Should these be visibile in both desktop and mobile mode?

dittaeva commented 11 years ago

Yes please.

dittaeva commented 11 years ago

I know that in mobile mode details of the logos will be barely visible, but that doesn't matter.

esisa commented 11 years ago

Ok, I try this out and then you need to check if I am doing it right or not.

dittaeva commented 11 years ago

Just let me know, and I'll check it out ASAP.

esisa commented 11 years ago

I have made the first attempt. Take a look and give me corrections. Also check the href attributes.

https://github.com/Kresendo/waymarked-trails-site/commit/561f774b81e2998f39ee20123ffdd0aaab198441

dittaeva commented 11 years ago

Looks good, but unfortunately this requirement from the EU does not seem to consider if things look good or not, so you need to:

Include all the text from the NPP logo and EU flag + reference to European Union. Which probably means that you'll have to shrink things and put the TG4NP logo above the EU flag to fit everything...
No needs for links, I'll link on the help pages.

esisa commented 11 years ago

Ok, thats just crazy :-)

Is this better? https://github.com/Kresendo/waymarked-trails-site/commit/e7830d6c40b029ecaf8b7a15662a921ffe72c622

dittaeva commented 11 years ago

Indeed, but yes, for the desktop version that is fine. Nothing on mobile now though. The search icon in the search bar is also working now, btw.

esisa commented 11 years ago

Yeah, the I fixed the search icon here https://github.com/Kresendo/waymarked-trails-site/commit/a2deca66bb578f1700edbcf4c8db0c5065fead14

I converted the NPP/EU logo 35px tall and 270px wide. So on most mobile screens there is not enough room for both the route.is logo and the NPP/EU logo.

dittaeva commented 11 years ago

Ah, ok, I can see it with horizontal view, but not the TG4NP-logo, could you make it so that as much as there is room for is shown, instead of all or nothing? On the iphone there should be room for the TG4NP logo in horizontal view.

There are also redrawing errors when changing from vertical to horizontal view, btw, and the scale bar should show above the footer. The zoom buttons and geolocate button should be as transparent as the header.

esisa commented 11 years ago

I only remove the TG4NP-logo when necessary. I works fine on my iPhone in horizontal view? When screen width is less than 490px I remove the TG4NP-logo and when we hit 400px I remove the NPP-EU logo as well.

I have seen some redrawing error as well. But I dont't think that stems from my work. I am not prioritizing those issues now. As for the other comments. What browser are you using? Can you send me some screenshots?