search

WNderitu / Jumia_webscraping-project

0 stars 0 forks source link

Jumia Webscrapping Project Review #1

Open ceciliawambui opened 2 weeks ago

ceciliawambui commented 2 weeks ago

What I like about your project

  1. The project is well done.
  2. The code is well structured and the flow of how web scrapping is done is perfect.
  3. The error handling aspect is a very good practice to handle any potential errors.
  4. The data storage is well done.
  5. Your code is readable due to the comments incorporated.

Areas of Improvement

  1. You can incorporate error handling for HTTP Requests i.e response.status_code == 200 to check for any request errors
  2. Your variable naming can be made more clear,eg. 'price_after_discnt' can be 'discounted_price'
WNderitu commented 2 weeks ago

Hello, thank you for the feedback. Noted on the areas of improvement. I have a question though on how to retrieve the original price of the items on jumia. When I inspected the code it was scripted in a way that was tricky to extract it.

WNderitu commented 2 weeks ago

Hello, improvements done on the code and I've pushed to repository. Please check