search

WOTCStrategyOverhaul / CovertInfiltration

A mod that overhauls the Covert Actions system to bring back the Infiltration mechanic from Long War 2
MIT License
21 stars 8 forks source link

Covert Action optional soldiers sometimes negate the wrong risk #551

Closed Grobobobo closed 4 years ago

Grobobobo commented 4 years ago

Save:

image

Xymanek commented 4 years ago

Likely same underlying issue as #493

Xymanek commented 4 years ago

Turns out that (vanilla behaviour) within 30 days after playing an ambush mission, the ambush risk is auto-negated.

Code reference:

https://github.com/X2CommunityCore/X2WOTCCommunityHighlander/blob/3c6eba4a22980af2eada617d0c12cf67c45e1ac9/X2WOTCCommunityHighlander/Src/XComGame/Classes/XComGameState_HeadquartersResistance.uc#L293-L298

https://github.com/X2CommunityCore/X2WOTCCommunityHighlander/blob/3c6eba4a22980af2eada617d0c12cf67c45e1ac9/X2WOTCCommunityHighlander/Src/XComGame/Classes/XComGameState_HeadquartersResistance.uc#L1820-L1836

https://github.com/X2CommunityCore/X2WOTCCommunityHighlander/blob/3c6eba4a22980af2eada617d0c12cf67c45e1ac9/X2WOTCCommunityHighlander/Src/XComGame/Classes/XComGameState_CovertAction.uc#L1198-L1205

Thanks a lot for the save @Grobobobo, this is actually pretty important for CI 😄 You might want to look into this for lwotc as well

Grobobobo commented 4 years ago

Lwotc disabled the ambush mission because the current one is garbage, but it certainly is good to know should we re-enable it.