WOTCStrategyOverhaul / CovertInfiltration

A mod that overhauls the Covert Actions system to bring back the Infiltration mechanic from Long War 2
MIT License
21 stars 8 forks source link

Ambush missions on non-abandoned plots generate with extra parcel when Mission Overhaul: Core is loaded #558

Closed h4ilst0rm closed 3 years ago

h4ilst0rm commented 4 years ago

XCOM 2 Screenshot 2020 07 03 - 09 38 02 54 XCOM 2 Screenshot 2020 07 03 - 09 38 09 82 XCOM 2 Screenshot 2020 07 03 - 09 44 14 71 XCOM 2 Screenshot 2020 07 03 - 09 44 29 98 XCOM 2 Screenshot 2020 07 03 - 09 47 06 39 XCOM 2 Screenshot 2020 07 03 - 09 47 12 95

Xymanek commented 4 years ago

Do you use any map packs? I recall testing all plots for that "hack" and never saw this issue, neither did any YT campaign so far...

h4ilst0rm commented 4 years ago

I do use a few map packs, though they were all disabled when testing this in skirmish mode. I did forget to clean configs, but just now did that and got the best one yet:

XCOM 2 Screenshot 2020 07 03 - 12 15 35 98 XCOM 2 Screenshot 2020 07 03 - 12 15 42 60

full modlist used:

Unsorted (2):
    TLP: Unlocker                                   TLP_UnlockEverything        1535023259  
    Skirmish Mode+                                  AllEquipmentsinSkirmish     1535761480  

CI core (13):
    WotC: robojumper's Squad Select                 robojumperSquadSelect_WotC  1122974240  
    Better Second Wave Mod Support                  BetterSecondWaveSupport     1149493976  
    [WOTC] Open Squad Select at any time            SquadSelectAtAnyTime        1529472981  
    Highlander for CI Beta 3                        X2WOTCCommunityHighlander   2122546411  
    Accurate Situation Report Beta                  AccurateSituationReport     2122561731  
    Living Space Beta                               LivingSpace                 2122563289  
    Infiltrator's Disguises Beta                    InfiltratorsDisguises       2126774922  
    Prototype Armoury Beta                          PrototypeArmoury            2126777138  
    Covert Infiltration Beta 3                      CovertInfiltration          2135314482  
    [WotC] Mod Config Menu                          ModConfigMenu               667104300   
    Pyrrhic Victories                               CatastrophicVictories       1531883724  
    [WotC] Mission Overhaul: Core                   WotC_MissionOverhaul_Core   1877944427  
    Alien Hunters Highlander Plugin for CI Beta 3   DLC2CommunityHighlander     2126773442  
Xymanek commented 4 years ago

I don't have this issue on that plot:

image

However, looking at your screenshot, the objective parcel is overlapping 2 other parcels (???), so I feel like the issue is not with the specific plot. Can you repro the same issue on all plots reliably?

h4ilst0rm commented 4 years ago

Yeah it is really strange how it seems to try and add an extra parcel and when there is no place for it the whole thing breaks.

I bit the bullet and verified files only for the issue to persist. With some additional fiddling around I found the culprit: Mission Overhaul: Core.

No idea as to how or why, but with overhaul active the extra parcel is present on all non-abandoned plot types. Quick check into overhauls configs + scripts didn't give me any insights, though there are some .umap files under /content/maps that could be related to this, though I have no idea what they are used for.

Tested also with map packs enabled which seemed to work as expected when not running overhaul (few tries in skirmish).

Xymanek commented 4 years ago

Related: #548