Slot reward appears that negates a nonexistent risk

WOTCStrategyOverhaul / CovertInfiltration

A mod that overhauls the Covert Actions system to bring back the Infiltration mechanic from Long War 2

MIT License

21 stars 8 forks source link

Slot reward appears that negates a nonexistent risk #657

Open cannonfodder1 opened 3 years ago

cannonfodder1 commented 3 years ago

Issue is likely related to the Reapers resistance order that prevents the risk of ambush on all covert actions. Discord ref: https://discord.com/channels/578606792448409610/639765305345835009/854168036986191884

Xymanek commented 3 years ago

In vanilla, optional slots that negate an already negated risk are simply not shown to the player.

Our options:

Leave everything as-is. Drawback: player confusion regarding negation of a non-existent risk
Hide "negates risk" hint on the slot. Drawback: player confusion regarding the "useless" optional slot and why some CAs have it and others do not
Hide slot if risk is already negated (vanilla). Drawback: player doesn't get the opportunity to reduce the other risk(s) as much (ambush rarely (never?) comes alone). This is also the most involved change, and we do not have another extended beta period to verify that it would work properly
Remove the Guarding Angels card. Drawback: the situation can resurface due to interactions with other mods

@cannonfodder1 thoughts?

cannonfodder1 commented 3 years ago

I believe that out of all those options, removing the "Negates Risk: X" banner has the least worst drawback. The optional slot won't be completely useless because additional risk reduction can be gained from it.

Xymanek commented 3 years ago

Looking at the code deeper, turns out that option isn't so simple simple either. The issue is that the reason "why was this negated" isn't saved anywhere, only that it was negated. So while we can easily hide the "negates ambush" on UISS, it would come back on UICAG post-launch and the report screen.

I'm once again considering removing GA, especially considering how powerful it in CI environment, especially for T1 card

cannonfodder1 commented 3 years ago

GA could possibly be changed to a different effect that doesn't cause the nonexistent counter issue and is easier to implement. One idea might be reducing the risk trigger chance of Ambushes by a certain percentage.

Xymanek commented 3 years ago

Ok, go ahead

cannonfodder1 commented 3 years ago

Change of plans, Guardian Angels will be removed and this issue will be revisited post-release.