if bad username and login are provided while using wp api v2, this co…

WP-API / Basic-Auth

Basic Authentication handler for the JSON API, used for development and debugging purposes

777 stars 287 forks source link

if bad username and login are provided while using wp api v2, this co… #29

Closed mnelson4 closed 4 years ago

mnelson4 commented 8 years ago

…mmit makes it so it also shows an error like it did with wp api v1. Because currently if you're using this plugin with WP API v2, it mostly works. Except if you provide a bad username and password combination, there is no error message like there was working with wp api v1. This can be troublesome if, for example, logged in admins can see all users, whereas someone who's not logged in can only see a subset.

mnelson4 commented 8 years ago

oups didn't mean to close pull request

Tug commented 4 years ago

Looks like this is outdated, master already uses the 'rest_authentication_errors' filter here. Should we close this?

mnelson4 commented 4 years ago

Good call, I didn't realize it at the time, but this PR was actually a duplicate of #23