WP-API / Basic-Auth

Basic Authentication handler for the JSON API, used for development and debugging purposes

777 stars 287 forks source link

Fix for Basic Auth not being passed through with PHP in CGI mode #32

Open graham73may opened 8 years ago

graham73may commented 8 years ago

1 Issue fixed.

PHP_AUTH_USER & PHP_AUTH_PW are now being set if PHP is using fast CGI

mnelson4 commented 8 years ago

FYI pulled into https://github.com/eventespresso/Basic-Auth

sebastienbarre commented 8 years ago

This is sorely needed, this was hard to track. Please consider merging.

kadamwhite commented 8 years ago

Just flagged this in core slack to see if @rmccue et al can take a look

bigandy commented 7 years ago

Any progress on this issue? For the moment I am using @mnelson4 version https://github.com/eventespresso/Basic-Auth which works A+

alkema commented 7 years ago

The solution developed here https://github.com/eventespresso/Basic-Auth is the best one in my opinion because it does not suggest any Apache-specific solutions. The handling of HTTP headers is best handled in PHP, then the plugin just works with any web server. Thanks @mnelson4!

kadamwhite commented 7 years ago

@rmccue Could you review this?

MrToph commented 6 years ago

Thanks so much, this fixed my issue with Basic Authentication not working :+1:

Ipstenu commented 4 years ago

This was approved a year ago.

A number of hosts use FastCGI and telling customers to use an htaccess workaround to force HTTP for auth is not really a good security practice. Can this please be revisited for WP 5.5?

graham73may commented 4 days ago

I know this is an incredibly old PR at this point but I've resolved the review comments in the hope that this might be merged one day.