WP-API / docs-v2

Documentation for version 2 of the API
http://v2.wp-api.org
58 stars 76 forks source link

`slug_update_spaceship` would not update meta if `$value` evaluates to `false` #162

Open TestValleySchool opened 8 years ago

TestValleySchool commented 8 years ago

If you check for ! $value in the validation in the example callback method slug_update_spaceship, a string value of '0' (or anything else that PHP evaluates to false) will be ignored and that post meta field will not be updated.

Since '0' might be a desired post meta value, I propose changing the validation on this line to instead check isset and ensure the string's length is >0.