search

WP-API / docs

The content for developer.wordpress.org/rest-api
https://developer.wordpress.org/rest-api
110 stars 615 forks source link

Update adding-custom-endpoints.md #101

Open abdul-alhasany opened 3 years ago

abdul-alhasany commented 3 years ago

Added a clarification for required property and empty values being allowed.

TimothyBJacobs commented 3 years ago

Thanks for the PR @kalimah-apps! I don't think this should be called out in an alert of its own, but rather alongside the required description.

abdul-alhasany commented 3 years ago

I added it as an alert because it was not clear. I assumed required covers the length too. But as long as it is added then it should be fine.

kadamwhite commented 1 year ago

@abdul-alhasany Hello there! It's been a while on this PR -- if you're still interested in seeing this change made, would you be able to update the patch? I agree with Timothy about making this a sub-bullet of the *required* argument description, instead of an alert.

Thank you

abdul-alhasany commented 1 year ago

@kadamwhite It has been a while and I have removed the branch that created this PR. I am not sure if I can update this patch. I might need to create a new PR with the proposed changes.