WP-API / menus-endpoints

Feature plugin for Menu Endpoints
43 stars 13 forks source link

Additional Ergonomic Issues #28

Closed spacedmonkey closed 4 years ago

spacedmonkey commented 5 years ago

What does it look like when a menu is reordered? It seems like this would require HTTP requests to each menu item to complete. We don't have a batch controller at the moment, but even if we did, we'd still have the overhead of dispatching internal requests for each menu item.

I think menu settings could cleanly be implemented into the menu controller.

Locations could as well, perhaps with the different locations defined by the Schema.

The URL structure is a bit confusing as well. /wp/v2/menus/{menu_id}/items/{item_id} would be more intuitive. Can a menu item belong to more than one menu? Can you have orphaned menu items? The current URL setup and linking somewhat implies that you can.

spacedmonkey commented 4 years ago

Closing as invalid