search

WP-API / menus-endpoints

Feature plugin for Menu Endpoints
43 stars 13 forks source link

widget schema update #33

Closed t0lya closed 5 years ago

kadamwhite commented 5 years ago

@let00 Thank you for contributing this PR! In order for us to review this, we'll need more information on what your proposed change is intended to do, and why it is necessary. Would you be able to provide that information?

I should also note that, per #35, we intend to repurpose this repository for the active menus work and create a new repository to hold these legacy widgets endpoints. Widgets work here is likely to be superseded by work within the Gutenberg repository.

t0lya commented 5 years ago

@kadamwhite WP_Widget class has gone through changes since the widgets endpoints have been touched. This PR updates the widgets endpoints to include all the new fields available in the WP_Widget class.

kadamwhite commented 5 years ago

@let00 Thanks for the clarification. Per #35 we have separated widgets code out from this repository; could I ask you to re-open this on the new widgets endpoints repository?

I should also re-emphasize that the widgets piece of these plugins may never become a merge candidate, based on developments within the Gutenberg project. I therefore thank you for the contribution but understand if you'd rather spend your time on a project that's more likely to see further development.