search

WP-API / menus-endpoints

Feature plugin for Menu Endpoints
43 stars 12 forks source link

Add menu location assignment #34

Closed spacedmonkey closed 4 years ago

spacedmonkey commented 5 years ago

Allow menu locations to be assigned in menus endpoint.

Fixes #25

TimothyBJacobs commented 5 years ago

@spacedmonkey the PR is currently listed as a draft on GH, is it ready for review?

spacedmonkey commented 5 years ago

@TimothyBJacobs I haven't added tests, so I marked it as a work in progress. I am going to work on tests, but until then, do feel free to add feedback.

spacedmonkey commented 5 years ago

@TimothyBJacobs This is ready to review now.

spacedmonkey commented 5 years ago

Any chance this could be reviewed next? This has tests and is good to go.

spacedmonkey commented 4 years ago

@TimothyBJacobs Can you review again, I have fixed tests.

spacedmonkey commented 4 years ago

@TimothyBJacobs Can you re-review. I have actioned all your feedback.

spacedmonkey commented 4 years ago

@TimothyBJacobs Why are we adding empty doc blcoks?

It is how the coding standards are setup. We can add comment to the tests later / check they go into core. But I thought we would want that comment to add ticket number at some point. I can remove them, but would mean tweaking the coding standards, which I would do in another PR. The empty comments don't both me that much...

spacedmonkey commented 4 years ago

@TimothyBJacobs I think we are good to go with this PR, can I merge?